Fix RelWithDebInfo to be release with debug info#11211
Merged
cmcfarlen merged 2 commits intoapache:masterfrom May 13, 2024
Merged
Fix RelWithDebInfo to be release with debug info#11211cmcfarlen merged 2 commits intoapache:masterfrom
cmcfarlen merged 2 commits intoapache:masterfrom
Conversation
JosiahWI
requested changes
Apr 4, 2024
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
Looks good, but could we add a brief comment explaining this was done for consistency between build types?
cmcfarlen
force-pushed
the
better-relwithdebinfo
branch
from
313d5e6 to
81d9733
Compare
Contributor
|
@dragon512 and @zwoop We talked about this in the PR/issue scrub and would like to have your input. No one felt strongly about having this in or not. |
cmcfarlen
added a commit
that referenced
this pull request
May 16, 2024
* Fix RelWithDebInfo to be release with debug info * Add comment (cherry picked from commit a7a150d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.